Add test for transitive dependency with local test scope #70
Conversation
This example project has a direct dependencies on Guice in compile scope and Guava in test scope. Guice depends on Guava, so the runtime classpath should include Guava, as it is required at runtime.
|
cc @cstamas |
|
Will take a peek on EU morning |
|
Seems we finally found a bug, a bug in Maven Core bug old 14 years 😄 This whole topic got "inflamed" as I documented "how should things work" (simple to prove with MIMA or even with Maven + circumvention): But Maven violates this, and this bug leads to issues like: |
|
This Maven PR apache/maven#1398 makes this reproducer work as expected (guava ends up in lib). And even more, all the Maven ITs did pass, which also explains how could this edge case lurk in there. |
Similar fix to m-assembly-p: do not rely on Maven Core to provide "runtime" resolution scope as it have issues, see: https://issues.apache.org/jira/browse/MNG-8041 Instead, use Resolver APIs directly to get what is needed. Contains several minor code improvements across Provisio maven-plugin module. Contains IT from jvanzyl#70 Fixes jvanzyl#71
Similar fix to m-assembly-p: do not rely on Maven Core to provide "runtime" resolution scope as it have issues, see: https://issues.apache.org/jira/browse/MNG-8041 Instead, use Resolver APIs directly to get what is needed. Contains several minor code improvements across Provisio maven-plugin module. Other changes in this PR: * added support for -X to dump proviso graph * marked Mojos as thread safe, removed now unneeded ask for resolution (as they use Resolver APIs) Contains IT from jvanzyl#70 Fixes jvanzyl#71
Similar fix to m-assembly-p: do not rely on Maven Core to provide "runtime" resolution scope as it have issues, see: https://issues.apache.org/jira/browse/MNG-8041 Instead, use Resolver APIs directly to get what is needed. Contains several minor code improvements across Provisio maven-plugin module. Other changes in this PR: * added support for -X to dump proviso graph * marked Mojos as thread safe, removed now unneeded ask for resolution (as they use Resolver APIs) Contains IT from #70 Fixes #71
|
Closing. Part of the fix: 1f17f55 |
This example project has a direct dependencies on Guice in compile scope and Guava in test scope. Guice depends on Guava, so the runtime classpath should include Guava, as it is required at runtime.
Note that this test currently fails on all versions of Maven, even though
ProvisioningMojorequestscompile+runtime.