Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35077][cdc] Add license checking CI scripts #3218

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

yuxiqian
Copy link
Contributor

Currently, Flink project has CI scripts checking if dependencies with incompatible licenses are introduced.

Flink CDC module heavily relies on external libraries (especially connectors), so running similar checking scripts during every CI would be helpful preventing developers introducing questionable dependencies by accident.

Copy link

@vahmed-hamdy vahmed-hamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuxiqian yuxiqian force-pushed the FLINK-35077 branch 2 times, most recently from 2461cc6 to 3b3db67 Compare April 23, 2024 10:10
@yuxiqian
Copy link
Contributor Author

Hi @PatrickRen, I just pushed a hotfix commit to lock dependency version and suppress potential breaking changes as follows:

The public API of some Rubyzip classes has been modernized to use named
parameters for optional arguments. Please check your usage of the
following classes:
  * `Zip::File`
  * `Zip::Entry`
  * `Zip::InputStream`
  * `Zip::OutputStream`

Please ensure that your Gemfiles and .gemspecs are suitably restrictive
to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).
See https://github.com/rubyzip/rubyzip for details. The Changelog also
lists other enhancements and bugfixes that have been implemented since
version 2.3.0.

Could you please help re-run the CI? Thanks!

Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuxiqian Thanks for the contribution! LGTM

@PatrickRen PatrickRen merged commit 58531e7 into apache:master Apr 24, 2024
14 checks passed
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants