-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages #3212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxiqian Thanks for the patch! Just a minor comment for the documentation.
It reminds me that there's an automatic license check in CI of Flink repo. Maybe we can also do it in Flink CDC: |
@PatrickRen Sure! Shall I add the license checking script in this PR or open another one? |
@yuxiqian I won't take it as a blocker. We can have a try to see if it is complex. |
Addressed in #3218. |
Seems removing connector jar dependencies breaks SQL Job E2e tests. Need to fix this first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxiqian Thanks for the update! LGTM
…icenses from fat jar packages (apache#3212)
This resolves FLINK-35055.
Currently, Flink CDC connector releases both slim and fat jars. Apart from CDC itself, all of its dependencies are packaged into fat jars, including some with incompatible licenses:
com.ibm.db2.jcc:db2jcc:db2jcc4
licensed under IBM's non-FOSS license (International Program License Agreement).mysql:mysql-connector-java
licensed under GPLv2 license, which is incompatible with Apache 2.0.mysql:mysql-connector-java
licensed under GPLv2 license, which is incompatible with Apache 2.0.com.oracle.ojdbc
licensed under Oracle's non-FOSS license (Oracle Free Use Terms and Conditions).This PR: