Simplify admin hash in the secret #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
willholley
requested changes
Jan 9, 2023
willholley
previously approved these changes
Jan 9, 2023
|
The changes look good. However, I think it would be a breaking change for anybody that followed the instructions at https://github.com/apache/couchdb-helm/tree/main/couchdb#installing-the-chart to create their own admin secret containing a Sorry not to have twigged this sooner - do you think you could bump the version to |
willholley
dismissed
their stale review
change is breaking so needs a major version bump
willholley
approved these changes
Jan 9, 2023
4 tasks
sebastien-helbert
pushed a commit
to sebastien-helbert/couchdb-helm
that referenced
this pull request
Jan 9, 2023
Replaces the `password.ini` field in the internal secret resource with a field `adminHash`. This simplifies the management of the admin hash but breaks compatibility with the previous `password.ini` if `createAdminSecret` is set to `false`, hence the major version bump.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is for simplifying the adminHash in the secret
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.