Simplify secrets to avoid dependencies on a file and keep only the se…

[rileyai-dev]

What this PR does / why we need it:

It simplifies the secret. Instead of relying on password.ini for the adminHash, it simply stores the value. It helps users better manage their own secret files when they set createAdminSecret to false.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.

• Chart Version bumped
• e2e tests pass
• Variables are documented in the README.md

[yekibud]

Hi @rileyai-dev . I've been getting the following on my PRs trying to run the e2e tests. It appears these tests are passing without any errors for you? Is there anything special about the way you runt the tests? I just run make test from the project root.

[rileyai-dev]

Hi @yekibud,

Thanks for the reply! Actually I haven't tried the test... I have created my own chart package and I am currently using it in my environment. I see that the test you run is mentioning 3.6.3 while I have bumped the version of the chart to 3.7.0 (I did so to reflect the change for users who might already have an existing secret).

Also I haven't built the package in this repo since I couldn't find instructions... so the index doesn't include this new chart and the package doesn't exist. Would appreciate if someone could package it.

[yekibud]

Oh, okay, I thought you had run the test because the "e2e tests pass" checkbox was checked in the PR. If you get a chance to run make test I would be curious to see if it passes for you or not.

I think building the package should just be creating a new tarball and updating the index with helm repo index docs. However, this doesn't seem to be updating the helm repo itself, when PRs are merged, which I noted in my current PR. So not sure if there's something wrong with the CI or a step I'm missing, as well.

[rileyai-dev]

@willholley Would highly appreciate if you could have a look at this. I added a new autoSetup feature to automatically finalize the cluster (set to false by default). It's very useful for fluxCD or equivalent tools!

[willholley]

@rileyai-dev the autoSetup feature seems like it should be a distinct PR, else it's tricky to untangle the changes related to each enhancement for review.

[rileyai-dev]

@willholley I have created a new PR-106 for the admin hash only. I will submit a new one for autoSetup asap.