Skip to content

Refactor giant if & add unit tests

Codecov / codecov/patch succeeded Oct 25, 2024 in 0s

21.18% of diff hit (target 15.78%)

View this Pull Request on Codecov

21.18% of diff hit (target 15.78%)

Annotations

Check warning on line 67 in api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java#L67 

Added line #L67 was not covered by tests

Check warning on line 69 in api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java#L69 

Added line #L69 was not covered by tests

Check warning on line 72 in api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/com/cloud/agent/api/to/PortForwardingRuleTO.java#L72 

Added line #L72 was not covered by tests

Check warning on line 162 in api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java#L162 

Added line #L162 was not covered by tests

Check warning on line 342 in api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java#L342 

Added line #L342 was not covered by tests

Check warning on line 108 in api/src/main/java/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java#L106-L108 

Added lines #L106 - L108 were not covered by tests

Check warning on line 146 in api/src/main/java/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java#L146 

Added line #L146 was not covered by tests

Check warning on line 96 in core/src/main/java/com/cloud/agent/resource/virtualnetwork/model/ForwardingRule.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/com/cloud/agent/resource/virtualnetwork/model/ForwardingRule.java#L94-L96 

Added lines #L94 - L96 were not covered by tests

Check warning on line 70 in engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java#L68-L70 

Added lines #L68 - L70 were not covered by tests

Check warning on line 74 in engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java#L72-L74 

Added lines #L72 - L74 were not covered by tests

Check warning on line 76 in engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java#L76 

Added line #L76 was not covered by tests

Check warning on line 79 in engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java#L78-L79 

Added lines #L78 - L79 were not covered by tests

Check warning on line 85 in engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/dao/FirewallRulesCidrsDaoImpl.java#L85 

Added line #L85 was not covered by tests

Check warning on line 111 in engine/schema/src/main/java/com/cloud/network/rules/PortForwardingRuleVO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/PortForwardingRuleVO.java#L109-L111 

Added lines #L109 - L111 were not covered by tests

Check warning on line 116 in engine/schema/src/main/java/com/cloud/network/rules/PortForwardingRuleVO.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/PortForwardingRuleVO.java#L114-L116 

Added lines #L114 - L116 were not covered by tests

Check warning on line 193 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L191-L193 

Added lines #L191 - L193 were not covered by tests

Check warning on line 197 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L195-L197 

Added lines #L195 - L197 were not covered by tests

Check warning on line 199 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L199 

Added line #L199 was not covered by tests

Check warning on line 201 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L201 

Added line #L201 was not covered by tests

Check warning on line 206 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L204-L206 

Added lines #L204 - L206 were not covered by tests

Check warning on line 208 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L208 

Added line #L208 was not covered by tests

Check warning on line 210 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L210 

Added line #L210 was not covered by tests

Check warning on line 214 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L213-L214 

Added lines #L213 - L214 were not covered by tests

Check warning on line 217 in engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java#L216-L217 

Added lines #L216 - L217 were not covered by tests

Check warning on line 415 in server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java#L415 

Added line #L415 was not covered by tests
View more details on Codecov