Skip to content

Refactor giant if & add unit tests

Codecov / codecov/project succeeded Oct 25, 2024 in 0s

15.78% (+0.00%) compared to 46201ee

View this Pull Request on Codecov

15.78% (+0.00%) compared to 46201ee

Details

Codecov Report

Attention: Patch coverage is 21.18644% with 93 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (46201ee) to head (8ad3a1b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/cloud/network/rules/RulesManagerImpl.java 0.00% 28 Missing ⚠️
.../network/rules/dao/PortForwardingRulesDaoImpl.java 0.00% 18 Missing ⚠️
...om/cloud/network/firewall/FirewallManagerImpl.java 52.94% 9 Missing and 7 partials ⚠️
...m/cloud/network/dao/FirewallRulesCidrsDaoImpl.java 0.00% 11 Missing ⚠️
.../com/cloud/network/rules/PortForwardingRuleVO.java 25.00% 6 Missing ⚠️
...a/com/cloud/agent/api/to/PortForwardingRuleTO.java 33.33% 3 Missing and 1 partial ⚠️
...and/user/firewall/UpdatePortForwardingRuleCmd.java 0.00% 4 Missing ⚠️
.../resource/virtualnetwork/model/ForwardingRule.java 40.00% 3 Missing ⚠️
...and/user/firewall/CreatePortForwardingRuleCmd.java 0.00% 2 Missing ⚠️
...a/com/cloud/network/router/CommandSetupHelper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##               main    #7081     +/-   ##
===========================================
  Coverage     15.78%   15.78%             
- Complexity    12565    12571      +6     
===========================================
  Files          5627     5627             
  Lines        492260   492344     +84     
  Branches      63882    60574   -3308     
===========================================
+ Hits          77710    77728     +18     
- Misses       406076   406141     +65     
- Partials       8474     8475      +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov