Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated files from old thrift #44772

Merged
merged 3 commits into from
Nov 19, 2024
Merged

GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated files from old thrift #44772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c68949c
GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated …
raulcd Nov 18, 2024
595eb23
Remove parquet_constants from build system, lint and rat exclusions
raulcd Nov 18, 2024
4f2ec26
Oops, read wrongly removed file from CMake
raulcd Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/build-support/lint_exclusions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
*RcppExports.cpp*
*_generated*
*arrowExports.cpp*
*parquet_constants.*
*parquet_types.*
*pyarrow_api.h
*pyarrow_lib.h
Expand Down
17 changes: 0 additions & 17 deletions cpp/src/generated/parquet_constants.cpp
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions cpp/src/generated/parquet_constants.h
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions cpp/src/parquet/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,6 @@ set(PARQUET_THRIFT_SOURCE_DIR "${ARROW_SOURCE_DIR}/src/generated/")

set_source_files_properties("${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.h"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.h"
PROPERTIES SKIP_PRECOMPILE_HEADERS ON
SKIP_UNITY_BUILD_INCLUSION ON)

Expand Down Expand Up @@ -178,7 +176,6 @@ set(PARQUET_SRCS
metadata.cc
xxhasher.cc
page_index.cc
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
platform.cc
printer.cc
Expand Down Expand Up @@ -307,7 +304,6 @@ add_arrow_lib(parquet

if(WIN32 AND NOT (ARROW_TEST_LINKAGE STREQUAL "static"))
add_library(parquet_test_support STATIC
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp")
target_link_libraries(parquet_test_support thrift::thrift)
list(PREPEND PARQUET_TEST_LINK_LIBS parquet_test_support)
Expand Down
2 changes: 0 additions & 2 deletions dev/release/rat_exclude_files.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ cpp/build-support/iwyu/*
cpp/cmake_modules/FindPythonLibsNew.cmake
cpp/examples/parquet/parquet-arrow/cmake_modules/FindArrow.cmake
cpp/src/parquet/.parquetcppversion
cpp/src/generated/parquet_constants.cpp
cpp/src/generated/parquet_constants.h
cpp/src/generated/parquet_types.cpp
cpp/src/generated/parquet_types.h
cpp/src/generated/substrait/*
Expand Down
Loading