GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated files from old thrift #44772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated files from old thrift
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
I was trying to find some easy C++ issues to do (so I can improve my skills there) and just found this non-coding quick fix. |
raulcd
requested review from
assignUser,
jonkeane,
kou and
wgtmac
as code owners
raulcd
changed the title
|
@github-actions crossbow submit -g java -g wheel |
|
Revision: 4f2ec26 Submitted crossbow builds: ursacomputing/crossbow @ actions-504c086939
|
wgtmac
approved these changes
Nov 19, 2024
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9d19450. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The files were generated 4 years ago with and old version of Thrift and don't seem necessary anymore.
What changes are included in this PR?
Remove obsolete files.
Are these changes tested?
No new tests added, just validate tests pass.
Are there any user-facing changes?
No