Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44657: [CI][Dev] Add write permission to the crossbow comment bot #44658

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kou
Copy link
Member

@kou kou commented Nov 6, 2024

Rationale for this change

It needs to write a comment to the target PR.

What changes are included in this PR?

Add write permission to only the crossbow comment bot.

Are these changes tested?

No.

Are there any user-facing changes?

No.

…t bot

It needs to write a comment to the target PR.
Copy link

github-actions bot commented Nov 6, 2024

⚠️ GitHub issue #44657 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, weird. That surprised me at first, but thinking about it again (+ realizing that permissions: pull-requests: write is about writing to the pull request on github itself, not the branch or anything which is what I had thought it was) of course it does.

Thanks and sorry for not catching that myself

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 6, 2024
@assignUser assignUser merged commit bbda6b1 into apache:main Nov 6, 2024
7 checks passed
@assignUser assignUser removed the awaiting merge Awaiting merge label Nov 6, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 6, 2024
@kou kou deleted the ci-commit-comment-crossbow branch November 6, 2024 21:14
@kou
Copy link
Member Author

kou commented Nov 6, 2024

No problem!

Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbda6b1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants