Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44648: [CI] Remove autotune and rebase from commentbot #44649

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jonkeane
Copy link
Member

@jonkeane jonkeane commented Nov 5, 2024

Rationale for this change

Removing code that doesn't work

What changes are included in this PR?

Deleting from the workflow

Are these changes tested?

Changes are part of CI

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 5, 2024
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this worked but since it doesn't, 🚮

@@ -26,8 +26,7 @@ on:

permissions:
contents: read
pull-requests: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, does the issue_assign job need this permission? I guess maybe not because it's modifying the issue and not the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is also an empirical question (easiest to test on main, I'm happy to follow on if it stops working)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take is just fine: #44654 (comment)

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 5, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Nov 5, 2024
@jonkeane jonkeane merged commit c6f076a into apache:main Nov 5, 2024
10 checks passed
@jonkeane jonkeane removed the awaiting merge Awaiting merge label Nov 5, 2024
@jonkeane jonkeane deleted the no_more_autotune branch November 5, 2024 20:45
@github-actions github-actions bot added the awaiting changes Awaiting changes label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes Awaiting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants