-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44648: [CI] Remove autotune and rebase from commentbot #44649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish this worked but since it doesn't, 🚮
@@ -26,8 +26,7 @@ on: | |||
|
|||
permissions: | |||
contents: read | |||
pull-requests: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, does the issue_assign
job need this permission? I guess maybe not because it's modifying the issue and not the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it does since it has its own permissions scoped anyway:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that is also an empirical question (easiest to test on main, I'm happy to follow on if it stops working)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take
is just fine: #44654 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rationale for this change
Removing code that doesn't work
What changes are included in this PR?
Deleting from the workflow
Are these changes tested?
Changes are part of CI
Are there any user-facing changes?
No