Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44578: [Release][Packaging] Verify wheel version #44593

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 31, 2024

Rationale for this change

We want to detect binary build from wrong source.

What changes are included in this PR?

Add version check. If we use wrong source, binary's version is X.Y.Z-SNAPSHOT not X.Y.Z. So the added check is failed.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #44578 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 31, 2024
@kou
Copy link
Member Author

kou commented Oct 31, 2024

@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 31, 2024

@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0

Copy link

Revision: a0f5435

Submitted crossbow builds: ursacomputing/crossbow @ actions-99deba0604

Task Status
verify-rc-binaries-wheels-linux-almalinux-8-amd64 GitHub Actions
verify-rc-binaries-wheels-linux-conda-latest-amd64 GitHub Actions
verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-13-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-14-arm64 GitHub Actions

@kou
Copy link
Member Author

kou commented Oct 31, 2024

Detected as expected:

AlmaLinux 8
https://github.com/ursacomputing/crossbow/actions/runs/11607347516/job/32320696524#step:6:890

++ python -c 'import pyarrow; print(pyarrow.cpp_build_info.version)'
+ arrow_cpp_version=18.0.0-SNAPSHOT
+ '[' 18.0.0-SNAPSHOT = 18.0.0 ']'
Failed to verify release candidate. See /tmp/arrow-18.0.0.Qi3E1 for details.

macos 13
https://github.com/ursacomputing/crossbow/actions/runs/11607347566/job/32320696687#step:7:343

++ python -c 'import pyarrow; print(pyarrow.cpp_build_info.version)'
+ arrow_cpp_version=18.0.0-SNAPSHOT
+ '[' 18.0.0-SNAPSHOT = 18.0.0 ']'
Failed to verify release candidate. See /var/folders/nj/wh528zms06j9t8y7bmlvpmjm0000gn/T/arrow-18.0.0.XXXXX.godSbxKj for details.

@raulcd
Copy link
Member

raulcd commented Oct 31, 2024

@github-actions crossbow submit -g wheel

Copy link

Revision: a0f5435

Submitted crossbow builds: ursacomputing/crossbow @ actions-bb57e85699

Task Status
python-sdist GitHub Actions
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-macos-monterey-cp39-cp39-amd64 GitHub Actions
wheel-macos-monterey-cp39-cp39-arm64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp313-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Oct 31, 2024

It seems some of the wheels jobs are trying to validate the version:

 ++ python -c 'import pyarrow; print(pyarrow.__version__)'
+ pyarrow_version=19.0.0.dev13
+ '[' 19.0.0.dev13 = HEAD ']'
Failed to verify release candidate. See /tmp/arrow-HEAD.9beIS for details.

@kou
Copy link
Member Author

kou commented Oct 31, 2024

Good catch! We should not check the version for this case.

@kou
Copy link
Member Author

kou commented Oct 31, 2024

@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0

Copy link

Revision: 426a754

Submitted crossbow builds: ursacomputing/crossbow @ actions-9ad7231ce8

Task Status
verify-rc-binaries-wheels-linux-almalinux-8-amd64 GitHub Actions
verify-rc-binaries-wheels-linux-conda-latest-amd64 GitHub Actions
verify-rc-binaries-wheels-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-13-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-14-arm64 GitHub Actions

@kou
Copy link
Member Author

kou commented Oct 31, 2024

@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64

Copy link

Revision: 426a754

Submitted crossbow builds: ursacomputing/crossbow @ actions-055c87307e

Task Status
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Nov 2, 2024
@raulcd raulcd merged commit ab0c857 into apache:main Nov 2, 2024
14 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Nov 2, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ab0c857.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the release-verify-binary-version branch November 3, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants