-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44578: [Release][Packaging] Verify wheel version #44593
Conversation
|
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0 |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0 |
Revision: a0f5435 Submitted crossbow builds: ursacomputing/crossbow @ actions-99deba0604 |
Detected as expected: AlmaLinux 8
macos 13
|
@github-actions crossbow submit -g wheel |
Revision: a0f5435 Submitted crossbow builds: ursacomputing/crossbow @ actions-bb57e85699 |
It seems some of the wheels jobs are trying to validate the version:
|
Good catch! We should not check the version for this case. |
@github-actions crossbow submit verify-rc-binaries-wheels-linux-* verify-rc-binaries-wheels-macos-* --param release=18.0.0 --param rc=0 |
Revision: 426a754 Submitted crossbow builds: ursacomputing/crossbow @ actions-9ad7231ce8 |
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64 |
Revision: 426a754 Submitted crossbow builds: ursacomputing/crossbow @ actions-055c87307e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ab0c857. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We want to detect binary build from wrong source.
What changes are included in this PR?
Add version check. If we use wrong source, binary's version is
X.Y.Z-SNAPSHOT
notX.Y.Z
. So the added check is failed.Are these changes tested?
Yes.
Are there any user-facing changes?
No.