Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release][Packaging] Verify version #44578

Closed
kou opened this issue Oct 30, 2024 · 1 comment
Closed

[Release][Packaging] Verify version #44578

kou opened this issue Oct 30, 2024 · 1 comment
Assignees
@kou
Labels
Component: Packaging Component: Release Type: enhancement
Milestone
19.0.0

Comments

@kou
Copy link
Member

kou commented Oct 30, 2024

Describe the enhancement requested

18.0.0 RC0's binaries didn't use apache-arrow-18.0.0-rc0 commit. It used wrong commit d0e7d07 .

We can detect this problem in verification process by checking version too.
If we use wrong commit, binaries have X.Y.Z-SNAPSHOT not X.Y.Z. So we can detect wrong commit.

Component(s)

Packaging, Release
kou added a commit to kou/arrow that referenced this issue Oct 31, 2024
@kou
apacheGH-44578: [Release][Packaging] Verify wheel version
daa2c59
@github-actions github-actions bot mentioned this issue Oct 31, 2024
Merged
raulcd pushed a commit that referenced this issue Nov 2, 2024
@kou
GH-44578: [Release][Packaging] Verify wheel version (#44593)
ab0c857 
### Rationale for this change

We want to detect binary build from wrong source. 

### What changes are included in this PR?

Add version check. If we use wrong source, binary's version is `X.Y.Z-SNAPSHOT` not `X.Y.Z`. So the added check is failed.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44578

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 19.0.0 milestone Nov 2, 2024
@raulcd
Copy link
Member

raulcd commented Nov 2, 2024

Issue resolved by pull request 44593
#44593

@raulcd raulcd closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Packaging Component: Release Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd