Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(derive): Move Batch, SingleBatch, and SpanBatch to op-alloy-protocol #695

Open
clabby opened this issue Oct 15, 2024 · 1 comment
Open

chore(derive): Move Batch, SingleBatch, and SpanBatch to op-alloy-protocol #695

clabby opened this issue Oct 15, 2024 · 1 comment
Assignees
@refcell
Labels
A-derive Area: kona-derive crate F-deps Flag: Updates dependencies K-chore Kind: chore

Comments

@clabby
Copy link
Collaborator

clabby commented Oct 15, 2024

Overview

Right now, Frame + Channel live in op-alloy-protocol, but the batch types still live in kona-derive. We should move the following types and associated helpers into op-alloy-protocol:

  1. Batch
  2. SingleBatch
  3. SpanBatch + sub-types.
@clabby clabby added A-derive Area: kona-derive crate F-deps Flag: Updates dependencies K-chore Kind: chore labels Oct 15, 2024
@refcell refcell mentioned this issue Oct 15, 2024
Draft
@refcell refcell self-assigned this Oct 15, 2024
@mahmudsudo
Copy link

can i take on this ?

This was referenced Oct 25, 2024
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this issue Oct 27, 2024
@refcell
feat(protocol): Batch Type (#186)
8ab745d 
### Description

Part of a port migrating the batch types from `kona-derive` to
`op-alloy`. See
[`kona#695`](anton-rs/kona#695).
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this issue Oct 27, 2024
@refcell
feat(protocol): Batch Validity (#187)
242d739 
### Description

Part of a port migrating the batch types from `kona-derive` to
`op-alloy`. See
[`kona#695`](anton-rs/kona#695).

This PR introduces the `BatchValidity` type.
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this issue Oct 27, 2024
@refcell
feat(protocol): SingleBatch Type (#188)
96666d1 
### Description

Part of a port migrating the batch types from `kona-derive` to
`op-alloy`. See
[`kona#695`](anton-rs/kona#695).

This PR introduces the `SingleBatch` type.
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this issue Oct 27, 2024
@refcell
feat(protocol): BatchValidationProvider (#189)
f831e15 
### Description

Part of a port migrating the batch types from `kona-derive` to
`op-alloy`. See
[`kona#695`](anton-rs/kona#695).

This PR introduces a validation trait that is used for span batch
validity checks.
This was referenced Oct 27, 2024
Merged
Open
Closed
Open
Open
Open
Open
Open
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this issue Oct 28, 2024
@refcell
feat(protocol): Batch Error Types (#190)
e307f18 
### Description

Ports batch error types to `op-alloy-protocol`.

### Provenance

Part of a port migrating the batch types from `kona-derive` to
`op-alloy`. See
[`kona#695`](anton-rs/kona#695).
@refcell refcell mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate F-deps Flag: Updates dependencies K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clabby @refcell @mahmudsudo