-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(derive): Move Batch
, SingleBatch
, and SpanBatch
to op-alloy-protocol
#695
Comments
clabby
added
A-derive
Area: kona-derive crate
F-deps
Flag: Updates dependencies
K-chore
Kind: chore
labels
Oct 15, 2024
can i take on this ? |
This was referenced Oct 25, 2024
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this issue
Oct 27, 2024
### Description Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](anton-rs/kona#695).
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this issue
Oct 27, 2024
### Description Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](anton-rs/kona#695). This PR introduces the `BatchValidity` type.
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this issue
Oct 27, 2024
### Description Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](anton-rs/kona#695). This PR introduces the `SingleBatch` type.
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this issue
Oct 27, 2024
### Description Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](anton-rs/kona#695). This PR introduces a validation trait that is used for span batch validity checks.
This was referenced Oct 27, 2024
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this issue
Oct 28, 2024
### Description Ports batch error types to `op-alloy-protocol`. ### Provenance Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](anton-rs/kona#695).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Right now,
Frame
+Channel
live inop-alloy-protocol
, but the batch types still live inkona-derive
. We should move the following types and associated helpers intoop-alloy-protocol
:Batch
SingleBatch
SpanBatch
+ sub-types.The text was updated successfully, but these errors were encountered: