Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): Batch Type #186

Merged
merged 3 commits into from
Oct 27, 2024
Merged

feat(protocol): Batch Type #186

merged 3 commits into from
Oct 27, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 25, 2024 •
edited
Loading

Description

Part of a port migrating the batch types from kona-derive to op-alloy. See kona#695.

@refcell
Copy link
Collaborator Author

refcell commented Oct 25, 2024 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell self-assigned this Oct 25, 2024
@refcell refcell added A-protocol Area: protocol crate C-port Category: ports code labels Oct 25, 2024
This was referenced Oct 25, 2024
Merged
Merged
@refcell refcell mentioned this pull request Oct 25, 2024
Merged
onbjerg
onbjerg approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol comment otherwise lgtm

crates/protocol/src/batch/type.rs Outdated Show resolved Hide resolved
@refcell refcell mentioned this pull request Oct 27, 2024
Draft
@refcell refcell added this pull request to the merge queue Oct 27, 2024
Merged via the queue into main with commit 8ab745d Oct 27, 2024
19 checks passed
@refcell refcell deleted the rf/feat/batch-ty branch October 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees

@refcell refcell

Labels
A-protocol Area: protocol crate C-port Category: ports code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @onbjerg