feat(protocol): Batch Utilities #191
Open
+107
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
refcell
force-pushed
the
rf/feat/batch-utils
branch
2 times, most recently
from
7f788bf
to
07ac367
Compare
This was referenced Oct 28, 2024
onbjerg
reviewed
Oct 28, 2024
refcell
force-pushed
the
rf/feat/batch-utils
branch
from
07ac367
to
3e9bba1
Compare
refcell
commented
Oct 28, 2024
Comment on lines
+271
to
+284
| /// Checks if the signature of the passed [TxEnvelope] is protected. | ||
| pub const fn is_protected_v(tx: &TxEnvelope) -> bool { | ||
| match tx { | ||
| TxEnvelope::Legacy(tx) => { | ||
| let v = tx.signature().v().to_u64(); | ||
| if 64 - v.leading_zeros() <= 8 { | ||
| return v != 27 && v != 28 && v != 1 && v != 0; | ||
| } | ||
| // anything not 27 or 28 is considered protected | ||
| true | ||
| } | ||
| _ => true, | ||
| } | ||
| } |
There was a problem hiding this comment.
FYI @onbjerg, I've upstreamed this to TxEnvelope in alloy: alloy-rs/alloy#1578
There was a problem hiding this comment.
We can refactor this out later once it lands in a release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports batch utilities to
op-alloy-protocol.Provenance
Part of a port migrating the batch types from
kona-derivetoop-alloy. Seekona#695.