Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ansys/actions/check-vulnerabilities to CI-CD #3505

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

clatapie
Copy link
Contributor

Description

This PR enables the ansys/actions/check-vulnerabilities to CI-CD.

Checklist

@clatapie clatapie self-assigned this Oct 23, 2024
@clatapie clatapie requested a review from a team as a code owner October 23, 2024 07:55
@clatapie clatapie requested review from germa89 and pyansys-ci-bot and removed request for a team October 23, 2024 07:55
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 23, 2024
@clatapie clatapie marked this pull request as draft October 23, 2024 07:59
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - first time we run it, the dev stage is expected to fail.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (e8248a3) to head (850670a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3505      +/-   ##
==========================================
+ Coverage   82.33%   82.34%   +0.01%     
==========================================
  Files          57       57              
  Lines       10007    10004       -3     
==========================================
- Hits         8239     8238       -1     
+ Misses       1768     1766       -2     

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, explanations are perfect. Thanks @clatapie - let's get it merged

@RobPasMue RobPasMue marked this pull request as ready for review October 23, 2024 13:10
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! :)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Roberto Pastor Muela <[email protected]>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clatapie clatapie enabled auto-merge (squash) October 23, 2024 13:47
@clatapie clatapie merged commit 2ba2b80 into main Oct 23, 2024
55 of 58 checks passed
@clatapie clatapie deleted the maint/add_action branch October 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants