Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify vulnerabilities check #1504

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

RobPasMue
Copy link
Member

Description

Simplify workflow call based on conditional evaluation. Thanks to @germa89 and @clatapie for trying this out on ansys/pymapdl#3505

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 23, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner October 23, 2024 13:49
@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (618a92f) to head (6203595).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1504   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          86       86           
  Lines        6974     6974           
=======================================
  Hits         6401     6401           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 150c19b into main Oct 23, 2024
38 of 40 checks passed
@RobPasMue RobPasMue deleted the ci/simplify-vulnerability-check branch October 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants