Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Create chamfer #5419

Merged
merged 11 commits into from
Nov 14, 2024
Merged

FIX: Create chamfer #5419

merged 11 commits into from
Nov 14, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Nov 12, 2024

Changes include:

  • fixing the aedt code in object_3d.py and element_3d.py
  • refactoring the chamfer method (f-string, check in symmetric case, improve error msg)
  • removing test duplicate
  • improve test on chamfer

Follow up of #5394

Close #5423

cathaychris and others added 2 commits November 12, 2024 20:51
There was a typo in the chamfer operation that assigned the angle to the "LeftDistance" property instead of the "Angle" property when chamfer type 2 (Left Distance-Angle) was used. There was also a typo that prevented type 2 from being accessed through the API.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys
Copy link
Collaborator Author

@cathaychris If you have some time, could you test the current changes to see if they fit your needs?
I'll double check the changes tomorrow but they seemed to be working locally.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (aa3f648) to head (1638005).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5419   +/-   ##
=======================================
  Coverage   84.38%   84.39%           
=======================================
  Files         140      140           
  Lines       58661    58669    +8     
=======================================
+ Hits        49504    49514   +10     
+ Misses       9157     9155    -2     

@cathaychris
Copy link
Contributor

@SMoraisAnsys Yes, it seems to work with both chamfer_type=2 and chamfer_type=3 now, thank you.

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review November 13, 2024 00:04
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Good job

MaxJPRey
MaxJPRey previously approved these changes Nov 14, 2024
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 14, 2024 12:57
@Samuelopez-ansys Samuelopez-ansys merged commit c592dac into main Nov 14, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/create-chamfer branch November 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when using chamfer type "Left Distance-Angle"
4 participants