-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Create chamfer #5419
FIX: Create chamfer #5419
Conversation
There was a typo in the chamfer operation that assigned the angle to the "LeftDistance" property instead of the "Angle" property when chamfer type 2 (Left Distance-Angle) was used. There was also a typo that prevented type 2 from being accessed through the API.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
@cathaychris If you have some time, could you test the current changes to see if they fit your needs? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5419 +/- ##
=======================================
Coverage 84.38% 84.39%
=======================================
Files 140 140
Lines 58661 58669 +8
=======================================
+ Hits 49504 49514 +10
+ Misses 9157 9155 -2 |
@SMoraisAnsys Yes, it seems to work with both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Good job
Co-authored-by: Maxime Rey <[email protected]>
Changes include:
object_3d.py
andelement_3d.py
chamfer
method (f-string, check in symmetric case, improve error msg)Follow up of #5394
Close #5423