Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Allow modeler object chamfer type "Left Distance-Angle" #5394

Closed
wants to merge 1 commit into from

Conversation

cathaychris
Copy link
Contributor

There was a typo in the chamfer operation that assigned the angle to the "LeftDistance" property instead of the "Angle" property when chamfer type 2 (Left Distance-Angle) was used. There was also a typo that prevented type 2 from being accessed through the API.

There was a typo in the chamfer operation that assigned the angle to the "LeftDistance" property instead of the "Angle" property when chamfer type 2 (Left Distance-Angle) was used. There was also a typo that prevented type 2 from being accessed through the API.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys
Copy link
Collaborator

Thanks for catching this issue @cathaychris. Due to some restrictions we have for testing, we won't be able to use the current PR to add your changes in the main branch. We'll create a new PR and cherry-pick your commits so that the CICD can run with the correct credentials. Note that you'll still be the authors of those changes, we'll only by the commiters.

@SMoraisAnsys
Copy link
Collaborator

While the changes make sense on the paper, they seem to behave strangely in practice. I'm trying things and will let you know when I've got something working as expected.
Thanks again @cathaychris for your contribution !

@cathaychris
Copy link
Contributor Author

Hi @SMoraisAnsys
Thanks for having a look. I agree it's strange. I tested it once and it seemed to behave, but sometimes does not (the property fields are not populated with the supplied arguments), seems to depend on the object history or something.
My workarounds for accessing full chamfer functionality are currently:
(1) manually calculate properties for the Left Distance - Right Distance configuration from any of the other cases (some basic trigonometry), and call that configuration,
(2) set any value and then access the node properties and manually set Left Distance, Right Distance, Angle.
Both are somewhat inelegant.

@SMoraisAnsys
Copy link
Collaborator

Hi @SMoraisAnsys Thanks for having a look. I agree it's strange. I tested it once and it seemed to behave, but sometimes does not (the property fields are not populated with the supplied arguments), seems to depend on the object history or something. My workarounds for accessing full chamfer functionality are currently: (1) manually calculate properties for the Left Distance - Right Distance configuration from any of the other cases (some basic trigonometry), and call that configuration, (2) set any value and then access the node properties and manually set Left Distance, Right Distance, Angle. Both are somewhat inelegant.

I was playing with AEDT and found that there is a bug with how Angle is forwarded. See #5419
Note that I cherry-pick your previous commit and added my changes afterward.
I'm closing this PR as forks can't run our tests / documentation build in CICD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants