Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename impedance multiplier parameter for clear usage #3328

Merged
merged 2 commits into from
Jul 27, 2023
Merged

rename impedance multiplier parameter for clear usage #3328

merged 2 commits into from
Jul 27, 2023

Conversation

fwlfHS
Copy link
Contributor

@fwlfHS fwlfHS commented Jul 26, 2023

Fix #3326

maxcapodi78
maxcapodi78 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

MaxJPRey
MaxJPRey approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fwlfHS fwlfHS mentioned this pull request Jul 27, 2023
Closed
@Samuelopez-ansys Samuelopez-ansys merged commit 5710c93 into ansys:main Jul 27, 2023
8 checks passed
@fwlfHS fwlfHS deleted the imp_mult branch July 27, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve parameter naming convention for hfss.set_impedance_multiplier()
4 participants
@fwlfHS @maxcapodi78 @MaxJPRey @Samuelopez-ansys