Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parameter naming convention for hfss.set_impedance_multiplier() #3326

Closed
fwlfHS opened this issue Jul 26, 2023 · 3 comments · Fixed by #3328
Closed

Improve parameter naming convention for hfss.set_impedance_multiplier() #3326

fwlfHS opened this issue Jul 26, 2023 · 3 comments · Fixed by #3328
Assignees
@fwlfHS
Labels
enhancement New features or code improvements

Comments

@fwlfHS
Copy link
Contributor

fwlfHS commented Jul 26, 2023

Description of the current limitations

As mentioned in #2358, the parameter given to hfss.set_impedance_multiplier() is the multiplier value not the impedance.

Code sample expected

change "impedance" to "multiplier"

Useful links and references

#2358
@fwlfHS fwlfHS added the enhancement New features or code improvements label Jul 26, 2023
@fwlfHS fwlfHS mentioned this issue Jul 26, 2023
Merged
@Samuelopez-ansys
Copy link
Member

Hi @fwlfHS ,

As mentioned in #2358 , are you going to do the implementation?

Thanks

@fwlfHS
Copy link
Contributor Author

fwlfHS commented Jul 27, 2023

Hi @Samuelopez-ansys, please see PR #3328

@Samuelopez-ansys
Copy link
Member

That's great! Thank you for your contribution 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fwlfHS fwlfHS

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename impedance multiplier parameter for clear usage fwlfHS/pyaedt
2 participants
@Samuelopez-ansys @fwlfHS