-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmware.vmware_rest: Generate action_groups #78
vmware.vmware_rest: Generate action_groups #78
Conversation
e41e7d6
to
24be674
Compare
6258368
to
b7a61a0
Compare
b7a61a0
to
3e89f15
Compare
@GomathiselviS Could you please review this? I've refactored the code a bit because it wasn't really feasible for a unit test... I mean, it wasn't a self-contained unit but part of a larger block of code. I hope it's OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've recommended adding a log message for clarity.
8f13200
to
11064d5
Compare
|
I think the aws collection could make use of this, too. Maybe changing: ansible.content_builder/plugins/action/generate_cloud_modules.py Lines 1238 to 1244 in e775adc
to something like:
or:
The latter would mean that BTW: This is jus a suggestion from my side. I won't implement this, I don't have anything to do with this collection 😏 |
@mariolenz Great, thanks! |
SUMMARY
Fixes #75
Generate action_groups for
vmware.vmware_rest
.edit: Tested in ansible-collections/vmware.vmware_rest#461
ISSUE TYPE
COMPONENT NAME
plugins/action/generate_cloud_modules.py
ADDITIONAL INFORMATION
Follow-up to #76 which I've closed accidentally and can't reopen again.