Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action_groups #475

Closed

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Add action_groups:

pip install black jsonschema jinja2==3.0.3 boto3 baron redbaron ruamel.yaml autoflake
git clone https://github.com/mariolenz/ansible.content_builder.git
cd ansible.content_builder
ansible-galaxy collection install .
cd -
git clone https://github.com/mariolenz/vmware.vmware_rest.git
mkdir -p /collections/ansible_collections/vmware/vmware_rest/tests
cp -r vmware.vmware_rest/tests/sanity /collections/ansible_collections/vmware/vmware_rest/tests
ansible-playbook build.yaml -e manifest_file=MANIFEST.yaml
cd vmware.vmware_rest/
git branch add_action_groups
git checkout add_action_groups
cp /collections/ansible_collections/vmware/vmware_rest/meta/runtime.yml meta/
echo -e '---\nminor_changes:\n- Add action_groups (https://github.com/ansible-collections/vmware.vmware_rest/issues/440).' > changelogs/fragments/440_add-action_groups.yaml
git add --all
git commit -m "Add action_groups"
git push --set-upstream origin add_action_groups

build.yaml:

---
- hosts: localhost
  gather_facts: yes
  roles:
    - ansible.content_builder.run

MANIFEST.yaml:

---
collection:
  requires_ansible: "2.14.0"
  path: /collections/ansible_collections/vmware/vmware_rest
  namespace: vmware
  name: vmware_rest
plugins:
  - type: module_openapi
    name: "vmware_rest"
    content: cloud
    api_object_path: vmware.vmware_rest/config/api_specifications/7.0.3
    resource: vmware.vmware_rest/config
    action: generate_all
    unique_key: ""
    rm_swagger_json: ""
    module_version: "1.0.0"
    author: "Ansible Cloud Team"
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

meta/runtime.yml

ADDITIONAL INFORMATION

#361
#440

cc @alinabuzachis @Yannik

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.18%. Comparing base (b757870) to head (a6b1311).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   34.18%   34.18%           
=======================================
  Files         143      143           
  Lines       11040    11040           
  Branches     2291     2291           
=======================================
  Hits         3774     3774           
  Misses       7266     7266           
Flag Coverage Δ
sanity 34.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariolenz mariolenz closed this Feb 24, 2024
@mariolenz mariolenz reopened this Feb 24, 2024
Copy link
Contributor

@alinabuzachis
Copy link
Collaborator

@mariolenz I guess we should probably implement a functionality for this in the content_builder to automatically generate the list.

@mariolenz
Copy link
Collaborator Author

I guess we should probably implement a functionality for this in the content_builder to automatically generate the list.

@alinabuzachis ansible-community/ansible.content_builder#78

I wonder why the action_groups didn't turn up in #481. Is my code buggy?

BTW As far as I understand from a discussion in the Ansible Community Working Group chat, it's planned to phase out content_builder. Do you know anything about this? (ansible/ansible-creator#106)

@mariolenz
Copy link
Collaborator Author

Closing in favor of #489 which contains action_groups.

@mariolenz mariolenz closed this Mar 20, 2024
@mariolenz mariolenz deleted the add_action_groups branch April 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants