Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add !important support to float mixin #10 #11

Merged
merged 1 commit into from
Apr 9, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions bi-app/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,19 @@

// float
// ------------------------------------------
@mixin bi-app-float-left {
float: $bi-app-left;
@mixin bi-app-float-left($important: '') {
float: $bi-app-left unquote($important);
}

@mixin bi-app-float-right {
float: $bi-app-right;
@mixin bi-app-float-right($important: '') {
float: $bi-app-right unquote($important);
}

@mixin float($direction) {
@mixin float($direction, $important: '') {
@if $direction == left {
@include bi-app-float-left;
@include bi-app-float-left($important);
} @else if $direction == right {
@include bi-app-float-right;
@include bi-app-float-right($important);
} @else {
float: $direction;
}
Expand Down
11 changes: 6 additions & 5 deletions bi-app/_variables-ltr.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
// ------------------------------------------
// left to right variables to be used by bi-app mixins
// authors:
// authors:
// twitter.com/anasnakawa
// twitter.com/victorzamfir
// licensed under the MIT license
// licensed under the MIT license
// http://www.opensource.org/licenses/mit-license.php
// ------------------------------------------

// namespacing variables with bi-app to
// avoid conflicting with other global variables
$bi-app-left : left;
$bi-app-right : right;
$bi-app-direction : ltr;
$bi-app-invert-direction: rtl;
$bi-app-right : right;
$bi-app-direction : ltr;
$bi-app-invert-direction : rtl;
$imp : !important;
11 changes: 6 additions & 5 deletions bi-app/_variables-rtl.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
// ------------------------------------------
// right to left variables to be used by bi-app mixins
// authors:
// authors:
// twitter.com/anasnakawa
// twitter.com/victorzamfir
// licensed under the MIT license
// licensed under the MIT license
// http://www.opensource.org/licenses/mit-license.php
// ------------------------------------------

// namespacing variables with bi-app to
// avoid conflicting with other global variables
$bi-app-left : right;
$bi-app-right : left;
$bi-app-direction : rtl;
$bi-app-invert-direction: ltr;
$bi-app-right : left;
$bi-app-direction : rtl;
$bi-app-invert-direction : ltr;
$imp : !important;