Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add !important support to float mixin #10 #11

Merged
merged 1 commit into from
Apr 9, 2015

Conversation

zeroxme
Copy link
Contributor

@zeroxme zeroxme commented Apr 2, 2015

Now it supports !important by passing $imp as a second optional argument to the mixin and it's backward compatible

@zeroxme
Copy link
Contributor Author

zeroxme commented Apr 9, 2015

@anasnakawa any updates?

@anasnakawa
Copy link
Owner

why your proposed pull request only affect float mixins, not the rest ?

why would I want to add support for the important only to floats ?

@zeroxme
Copy link
Contributor Author

zeroxme commented Apr 9, 2015

Because issue #10 was only about float

@anasnakawa
Copy link
Owner

Sorry, on github you could easily forget an open pull request,
sometimes I wish github provide a mark as unread feature.

anasnakawa added a commit that referenced this pull request Apr 9, 2015
add !important support to float mixin #10, thanks @izer0x !
@anasnakawa anasnakawa merged commit 334e7a3 into anasnakawa:master Apr 9, 2015
@zeroxme
Copy link
Contributor Author

zeroxme commented Apr 9, 2015

ok thanks, i'll try to work on other mixins as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants