Moved code into more cohesive modules #2013
clippy
18 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 18 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.1 (a28077b28 2023-12-04)
- cargo 1.74.1 (ecb9851af 2023-10-18)
- clippy 0.1.74 (a28077b 2023-12-04)
Annotations
Check failure on line 197 in src/lazy/encoder/write_as_ion.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/lazy/encoder/write_as_ion.rs:197:16
|
197 | fn as_sexp(self) -> SExpTypeHint<Self, T>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`
Check failure on line 301 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/mod.rs:301:13
|
301 | &*self.values_writer.allocator,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
Check failure on line 244 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/mod.rs:244:13
|
244 | &*self.values_writer.allocator,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
Check failure on line 219 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/mod.rs:219:51
|
219 | BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 555 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:555:52
|
555 | BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer)
| ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 421 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:421:71
|
421 | let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 418 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:418:64
|
418 | let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 407 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/value_writer.rs:407:25
|
407 | let allocator = &*self.allocator;
| ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`
Check failure on line 269 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:269:13
|
269 | &self.allocator,
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 197 in src/lazy/encoder/write_as_ion.rs
github-actions / clippy
methods called `as_*` usually take `self` by reference or `self` by mutable reference
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/lazy/encoder/write_as_ion.rs:197:16
|
197 | fn as_sexp(self) -> SExpTypeHint<Self, T>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`
Check failure on line 301 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/mod.rs:301:13
|
301 | &*self.values_writer.allocator,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
Check failure on line 244 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/mod.rs:244:13
|
244 | &*self.values_writer.allocator,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
Check failure on line 219 in src/lazy/encoder/binary/mod.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/mod.rs:219:51
|
219 | BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 555 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:555:52
|
555 | BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer)
| ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 421 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:421:71
|
421 | let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 418 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:418:64
|
418 | let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator);
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 407 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
deref on an immutable reference
error: deref on an immutable reference
--> src/lazy/encoder/binary/value_writer.rs:407:25
|
407 | let allocator = &*self.allocator;
| ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`
Check failure on line 269 in src/lazy/encoder/binary/value_writer.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lazy/encoder/binary/value_writer.rs:269:13
|
269 | &self.allocator,
| ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`