Code Coverage

Moved code into more cohesive modules #2013

Triggered via push December 8, 2023 15:17

zslayton

pushed 93c824a

new-binary-writer

Status Success

Total duration 2m 56s

Artifacts –

coverage.yml

on: push

Matrix: Build and Test

Annotations

18 errors and 5 warnings

methods called `as_*` usually take `self` by reference or `self` by mutable reference: src/lazy/encoder/write_as_ion.rs#L197

error: methods called `as_*` usually take `self` by reference or `self` by mutable reference --> src/lazy/encoder/write_as_ion.rs:197:16 | 197 | fn as_sexp(self) -> SExpTypeHint<Self, T>; | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`

deref on an immutable reference: src/lazy/encoder/binary/mod.rs#L301

error: deref on an immutable reference --> src/lazy/encoder/binary/mod.rs:301:13 | 301 | &*self.values_writer.allocator, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

deref on an immutable reference: src/lazy/encoder/binary/mod.rs#L244

error: deref on an immutable reference --> src/lazy/encoder/binary/mod.rs:244:13 | 244 | &*self.values_writer.allocator, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/mod.rs#L219

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/mod.rs:219:51 | 219 | BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L555

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:555:52 | 555 | BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer) | ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L421

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:421:71 | 421 | let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L418

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:418:64 | 418 | let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

deref on an immutable reference: src/lazy/encoder/binary/value_writer.rs#L407

error: deref on an immutable reference --> src/lazy/encoder/binary/value_writer.rs:407:25 | 407 | let allocator = &*self.allocator; | ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref = note: `-D clippy::borrow-deref-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L269

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:269:13 | 269 | &self.allocator, | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

methods called `as_*` usually take `self` by reference or `self` by mutable reference: src/lazy/encoder/write_as_ion.rs#L197