Remove Modernizr #4273
Merged
Remove Modernizr #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jon-kirwan
force-pushed
the
remove-modernizr
branch
from
b2d3a1b
to
946d884
Compare
MartinJJones
approved these changes
Oct 3, 2024
jon-kirwan
force-pushed
the
remove-modernizr
branch
from
946d884
to
b128b45
Compare
Thanks again for the review 😎 Good point, I'll add it as a breaking change (and also updated the description above). |
jon-kirwan
force-pushed
the
remove-modernizr
branch
from
b128b45
to
6ef0ea1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove Modernizr
Why
Although Modernizr is included in the admin layout, which is utilised by various publishing applications, none of these applications seem to use the included browser features (
flexbox,flexbox-tweener, history API), except for the printshiv which enables HTML5 elements to be styled when printed in Internet Explorer versions 6-8.Anything else
Marked as a breaking change due to the potential effect on printing in older versions of IE. I recommend reviewing any printed pages that use the admin layout.