Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizr isn't needed #2240

Closed
andysellick opened this issue Aug 2, 2021 · 2 comments · Fixed by #4273
Closed

Modernizr isn't needed #2240

andysellick opened this issue Aug 2, 2021 · 2 comments · Fixed by #4273
Labels
acknowledged This issue has been triaged. breaking change A breaking change is present in this issue or pull request

Comments

@andysellick
Copy link
Contributor

We have modernizr in the components gem but it only appears to be used on the admin layout, targeting browsers less than IE9.

We should investigate whether we really need it and whether it can be removed.

It was introduced in this PR: #422

@andysellick
Copy link
Contributor Author

Admin layout isn't used on the public site - only in publishing applications (think just content-publisher and content-data) where users may be stuck using older browsers, so we should probably still support them.

@andysellick andysellick added the acknowledged This issue has been triaged. label Jul 6, 2022
@MartinJJones MartinJJones added the breaking change A breaking change is present in this issue or pull request label Jul 19, 2024
@jon-kirwan
Copy link
Contributor

I’m wondering if we might actually be able to remove Modernizr now.

The gem version of Modernizr has the following configuration:

  • Flexbox
  • Flexbox (tweener)
  • History API
  • html5 printshiv
  • Add CSS classes (default)

I can’t find any 'no feature' styles configured for no-flexbox or no-flexboxtweener anywhere in the publishing applications (or for anywhere that uses the admin template). I searched for no-flexbox and no-flexboxtweener.
Same for the History API
Finally, there's the printshiv option (allowing HTML5 elements to be styled and contain children while being printed in IE 6-8). Is it safe to assume that printing admin pages in browsers older than IE9 isn't a major requirement?

The admin template is used by:

  • Publisher
  • Local Links Manager
  • Places Manager (formerly Imminence)
  • Collections Publisher
  • Content Data Admin
  • Manuals Publisher
  • Search Admin.

@jon-kirwan jon-kirwan linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged This issue has been triaged. breaking change A breaking change is present in this issue or pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants