Upgrade to Sidekiq 7 #1493
Merged
Upgrade to Sidekiq 7 #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
sidekiq-7
branch
3 times, most recently
from
288335c to
0455c07
Compare
brucebolt
force-pushed
the
sidekiq-7
branch
2 times, most recently
from
7b60373 to
7d0ae6c
Compare
brucebolt
force-pushed
the
sidekiq-7
branch
2 times, most recently
from
0d1773a to
17da129
Compare
We have now upgraded to Sidekiq 7, so don't need to require strict arguments in preparation for switching, as this version includes that requirement by default.
`Sidekiq::Worker` has been deprecated in Sidekiq 7, so we need to replace it with `Sidekiq::Job`, and then rename the workers to be jobs.
`Sidekiq::Worker` has been deprecated in Sidekiq 7, so we need to replace it with `Sidekiq::Job`, and then rename the workers to be jobs.
`Sidekiq::Worker` has been deprecated in Sidekiq 7, so we need to replace it with `Sidekiq::Job`, and then rename the workers to be jobs.
A [bug in version 8.0.8](mhenrixon/sidekiq-unique-jobs#846) means jobs never get processed when using `until_and_while_executing` lock type. Therefore pinning to use an earlier version that does not have this issue.
brucebolt
force-pushed
the
sidekiq-7
branch
from
17da129 to
ad280c6
Compare
Gweaton
approved these changes
Sep 24, 2024
brucebolt
added a commit
that referenced
this pull request
Sep 25, 2024
This is the suggestion in the Sidekiq FAQs: https://github.com/sidekiq/sidekiq/wiki/FAQ#how-do-i-safely-rename-a-worker The workers were renamed in #1493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
govuk_sidekiqto 9.0.0, which in turn upgrades Sidekiq to 7.*.After deployment, the
redis_namespace:remove_namespacerake task will need to be immediately run, to retain any jobs that were queued before the upgrade was deployed.Trello card