Skip to content

Commit

Permalink
Move rspec-sidekiq to test group
Browse files Browse the repository at this point in the history
This gem is being installed in the `development` environment, meaning it
runs when using the application locally, meaning jobs don't actually get
enqueued.

Moving it to be `test` only, since that is the only time it is actually
needed.
  • Loading branch information
brucebolt committed Sep 23, 2024
1 parent fe5f6b5 commit 288335c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
5 changes: 4 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ group :development, :test do
gem "pact", require: false
gem "pact_broker-client", require: false
gem "rspec-rails"
gem "rspec-sidekiq"
gem "rubocop-govuk"
gem "simplecov"
gem "webmock", require: false
Expand All @@ -42,3 +41,7 @@ end
group :development do
gem "listen"
end

gem "test" do
gem "rspec-sidekiq"

Check failure on line 46 in Gemfile

View workflow job for this annotation

GitHub Actions / Lint Ruby / Run RuboCop

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `rspec-sidekiq` should appear before `test`.
end
10 changes: 4 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,6 @@ GEM
rspec-expectations (~> 3.13)
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-sidekiq (5.0.0)
rspec-core (~> 3.0)
rspec-expectations (~> 3.0)
rspec-mocks (~> 3.0)
sidekiq (>= 5, < 8)
rspec-support (3.13.1)
rubocop (1.64.1)
json (~> 2.3)
Expand Down Expand Up @@ -668,6 +663,7 @@ GEM
ruby-vips (2.2.1)
ffi (~> 1.12)
ruby2_keywords (0.0.5)
rubytest (0.8.1)
securerandom (0.3.1)
sentry-rails (5.19.0)
railties (>= 5.0)
Expand Down Expand Up @@ -719,6 +715,8 @@ GEM
table_print (1.5.7)
term-ansicolor (1.11.2)
tins (~> 1.0)
test (1.0.0)
rubytest
thor (1.3.2)
timeout (0.4.1)
tins (1.33.0)
Expand Down Expand Up @@ -778,13 +776,13 @@ DEPENDENCIES
rails (= 7.2.1)
rails-controller-testing
rspec-rails
rspec-sidekiq
rubocop-govuk
sentry-sidekiq
sidekiq-unique-jobs
simplecov
sprockets-rails
state_machines-mongoid
test
webmock

BUNDLED WITH
Expand Down

0 comments on commit 288335c

Please sign in to comment.