Meshing: fix in graphcut weighting and minor sampling improvements #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue on some datasets where the graphcut prefers to stay around the bbox.
extra points are now based on inflated bbox
…th map files Also add some log.
fcastan
force-pushed
the
fix/meshingGraphCut
branch
from
18e281b
to
2be0ff0
Compare
mugulmd
reviewed
Aug 28, 2023
| for(int camid = 0; camid < cams.size(); camid++) | ||
| { | ||
| int rc = cams[camid]; | ||
| { | ||
| const Point3d p(_mp.CArr[rc].x, _mp.CArr[rc].y, _mp.CArr[rc].z); | ||
| std::size_t vi; | ||
| double sq_dist; | ||
| // std::size_t vi; |
There was a problem hiding this comment.
Is there any reason to keep the code that's been commented out ?
mugulmd
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features list
2 bug fixes:
1 library update:
Update the way we create helper points to improve performances and to improve distribution and noise level: