fix: user compilation config lose #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这里 deep merge 的处理太复杂了，后面考虑直接在 API 层面支持 deepmerge 的 option，类似 modifyUserConfig |
linbudu599
previously approved these changes
Oct 10, 2023
|
related to #6342 |
ClarkXia
previously approved these changes
Oct 10, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/next #6568 +/- ##
=============================================
Coverage 79.94% 79.94%
=============================================
Files 216 216
Lines 18812 18812
Branches 2441 2441
=============================================
Hits 15040 15040
Misses 3741 3741
Partials 31 31 ☔ View full report in Codecov by Sentry. |
ClarkXia
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：通过 userConfig 设置的 swc 编译配置（比如 syntaxFeatures.exportDefaultFrom），经过
plugin-rax-compat插件处理后会丢失