Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.4 #6550

Merged
merged 14 commits into from
Oct 12, 2023
Merged

Release 3.3.4 #6550

merged 14 commits into from
Oct 12, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Sep 26, 2023

* fix: hasDocument should check jsx

* chore: add js for document
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (adf1fa4) 79.98% compared to head (c6386d9) 79.95%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6550      +/-   ##
==========================================
- Coverage   79.98%   79.95%   -0.03%     
==========================================
  Files         216      216              
  Lines       18793    18816      +23     
  Branches     2437     2442       +5     
==========================================
+ Hits        15031    15044      +13     
- Misses       3732     3741       +9     
- Partials       30       31       +1     
Files Coverage Δ
packages/ice/src/bundler/rspack/getConfig.ts 98.95% <100.00%> (+0.03%) ⬆️
packages/ice/src/bundler/rspack/index.ts 91.66% <100.00%> (-0.18%) ⬇️
packages/ice/src/utils/getRoutePaths.ts 100.00% <100.00%> (ø)
packages/runtime/src/requestContext.ts 98.14% <100.00%> (+0.07%) ⬆️
packages/ice/src/createService.ts 88.42% <0.00%> (-0.25%) ⬇️
packages/runtime/src/routes.tsx 74.02% <50.00%> (-0.87%) ⬇️
packages/ice/src/service/ServerRunner.ts 90.43% <66.66%> (-1.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

linbudu599 and others added 12 commits September 27, 2023 10:25
* fix: update route config when dataLoader is not defined

* chore: test case
* fix: deal with json file when use on-demand compile

* chore: changeset
* fix: get flatten routes which nested level more than 3

* fix: lint
* fix: compatible with query parsing errors caused by ctx.req.url  error in the fc environment

* chore: add changelog
* feat: add type defination of runApp

* chore: changeset
* fix: compatible with win32 when config themePackage

* fix: compatible with win32 when custom icon file

* chore: update change log
* fix: export createElement for react

* fix: modify import source

* fix: dev server runner
* fix: user compilation config lose

* chore: changeset

* chore: add todo
@ClarkXia ClarkXia changed the title [WIP] Release 3.3.4 Release 3.3.4 Oct 12, 2023
@ClarkXia ClarkXia added the need review Need Review label Oct 12, 2023
@ClarkXia ClarkXia merged commit 99635bc into master Oct 12, 2023
7 checks passed
@ClarkXia ClarkXia deleted the release/next branch October 12, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants