Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused use in doctest #363

Closed
wants to merge 1 commit into from
Closed

Remove unused use in doctest #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ impl<W: Write> Builder<W> {
/// # Examples
///
/// ```
/// use std::fs;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw that Clippy isn't running in CI, and there are quite a few warnings: https://gist.github.com/schneems/fd26378009f9ac28ef282226de6ba5e7. Before going overboard, I wanted to send this one small change. In searching history to see if that's intentional, I saw #79 (comment) where you prefer a different style than Clippy suggests (which makes me feel that you would be opposed to adding a clippy check to CI).

/// use tar::Builder;
///
/// let mut ar = Builder::new(Vec::new());
Expand Down