Remove unused use in doctest
#363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `use std::fs` in the for `append_dir_all` tests is not used. We can simplify this example by removing it.
schneems
commented
Jun 6, 2024
| @@ -365,7 +365,6 @@ impl<W: Write> Builder<W> { | |||
| /// # Examples | |||
| /// | |||
| /// ``` | |||
| /// use std::fs; | |||
There was a problem hiding this comment.
I also saw that Clippy isn't running in CI, and there are quite a few warnings: https://gist.github.com/schneems/fd26378009f9ac28ef282226de6ba5e7. Before going overboard, I wanted to send this one small change. In searching history to see if that's intentional, I saw #79 (comment) where you prefer a different style than Clippy suggests (which makes me feel that you would be opposed to adding a clippy check to CI).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
use std::fsin the forappend_dir_alltests is not used. We can simplify this example by removing it.