feat: Implement tabs.update
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie632
force-pushed
the
feat/add-tabs-update
branch
2 times, most recently
from
6547e0e to
2ba35c8
Compare
feat: add tabs update feat: add tabs update
charlie632
force-pushed
the
feat/add-tabs-update
branch
from
2ba35c8 to
59b1dc9
Compare
charlie632
commented
Aug 20, 2024
Comment on lines
+159
to
+163
| // @ts-expect-error the type expects an overload | ||
| async update( | ||
| tabIdOrUpdateInfo: number | undefined | Tabs.UpdateUpdatePropertiesType, | ||
| optionalUpdateInfo: Tabs.UpdateUpdatePropertiesType | never, | ||
| ) { |
There was a problem hiding this comment.
note: TS was complaining here. There is an overload https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/update#syntax, as you can pass one or two parameters. I opted to add the type annotation for all of the possible combinations.
aklinker1
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an in-memory implementation of
tab.update.