feat: Implement tabs.update (#68)

aklinker1 · Aug 26, 2024 · 2bc4d7c · 2bc4d7c
1 parent f174a54
commit 2bc4d7c
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/packages/fake-browser/src/apis/tabs.ts b/packages/fake-browser/src/apis/tabs.ts
@@ -78,6 +78,7 @@ export const tabs: BrowserOverrides['tabs'] = {
       pinned: createProperties.pinned ?? false,
       windowId: window.id,
       id: getNextTabId(),
+      url: createProperties.url,
     };
     const fullTab = mapTab(newTab);
     await onCreated.trigger(fullTab);
@@ -155,6 +156,36 @@ export const tabs: BrowserOverrides['tabs'] = {
     await onHighlighted.trigger({ tabIds, windowId: window!.id! });
     return window!;
   },
+  // @ts-expect-error the type expects an overload
+  async update(
+    tabIdOrUpdateInfo: number | undefined | Tabs.UpdateUpdatePropertiesType,
+    optionalUpdateInfo: Tabs.UpdateUpdatePropertiesType | never,
+  ) {
+    let updateInfo: Tabs.UpdateUpdatePropertiesType;
+    if (tabIdOrUpdateInfo !== undefined && typeof tabIdOrUpdateInfo === 'object') {
+      updateInfo = tabIdOrUpdateInfo;
+    } else {
+      updateInfo = optionalUpdateInfo;
+    }
+
+    let tabId: number;
+    if (typeof tabIdOrUpdateInfo === 'number') {
+      tabId = tabIdOrUpdateInfo;
+    } else {
+      const currentWindow = await windows.getCurrent();
+      tabId = currentWindow.tabs!.find(tab => tab.active)!.id!;
+    }
+
+    const tab = await tabs.get(tabId);
+    if (!tab) throw new Error('Tab not found');
+
+    const updatedTab = { ...tab, ...updateInfo };
+    const tabIndex = tabList.findIndex(tab => tab.id === tabId);
+    tabList[tabIndex] = updatedTab;
+    const fullTab = mapTab(updatedTab);
+    await onUpdated.trigger(fullTab.id!, updateInfo, fullTab);
+    return fullTab;
+  },
   async remove(tabIds) {
     const ids = Array.isArray(tabIds) ? tabIds : [tabIds];
     for (const id of ids) {

diff --git a/packages/fake-browser/src/types.ts b/packages/fake-browser/src/types.ts
@@ -70,7 +70,7 @@ export interface BrowserOverrides {
   };
   tabs: Pick<
     Tabs.Static,
-    'get' | 'getCurrent' | 'create' | 'duplicate' | 'query' | 'highlight' | 'remove'
+    'get' | 'getCurrent' | 'create' | 'duplicate' | 'query' | 'highlight' | 'remove' | 'update'
   > & {
     resetState(): void;
     onCreated: EventForTesting<[tab: Tabs.Tab]>;