Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in white cards #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyzoid
Copy link
Contributor

@tyzoid tyzoid commented Aug 6, 2018

No description provided.

@ajanata
Copy link
Owner

ajanata commented Aug 7, 2018

I'm leery about merging this since the current card database is based on an import from a file provided directly by CAH; any mistakes really should be fixed directly in the source file (or at least by adding a feature to the card importer to automatically fix them up on re-import). And this doesn't help people using the sqlite file, and it'd skew metrics information since the card text will have changed.

Also I'm pretty sure there are a lot more errors than this.

@tyzoid
Copy link
Contributor Author

tyzoid commented Aug 7, 2018

Oh, I'm sure. These were just the two that I fixed in my db. I understand not wanting to merge this one in it's current state, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants