Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: LIving -> Living #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo: LIving -> Living #199

wants to merge 1 commit into from

Conversation

AXDOOMER
Copy link

I saw this small mistake while playing.

@ajanata
Copy link
Owner

ajanata commented Nov 13, 2018

I'm going to copy the comment I left in #186:

I'm leery about merging this since the current card database is based on an import from a file provided directly by CAH; any mistakes really should be fixed directly in the source file (or at least by adding a feature to the card importer to automatically fix them up on re-import). And this doesn't help people using the sqlite file, and it'd skew metrics information since the card text will have changed.

Also I'm pretty sure there are a lot more errors than this.

@AXDOOMER
Copy link
Author

the current card database is based on an import from a file provided directly by CAH; any mistakes really should be fixed directly in the source file

@ajanata Where do you get the file from CAH? I would contact them so they fix the source file.

@ajanata
Copy link
Owner

ajanata commented Dec 8, 2018

At this point I've given up hope of actually hearing anything back from them... I should just make a copy of the file and fix the errors there, then re-run the import... but they I'd still have the issue of the gameplay metrics not being correct after fixing the typos. Meh. I honestly don't know how I want to handle this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants