feat: add support for DaskExecutor
#816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherusk
force-pushed
the
feature/dask_executor
branch
11 times, most recently
from
94892d5 to
9a115cf
Compare
|
@thesuperzapper this should be it. Please give it a gander for now. I've not tested this outside of this PR yet. |
Signed-off-by: Matthias Tafelmeier <[email protected]>
Define dask executor as component in values and reflect chart dependency in chart config. Signed-off-by: Matthias Tafelmeier <[email protected]>
Reflect new executor type DaskExecutor. Signed-off-by: Matthias Tafelmeier <[email protected]>
Airflow does need the dask scheduler endpoint configured. That is done as for the other config vars via env vars. We also autodetect the dask sub chart release to automate generating the connection string from airflow to the dask cluster. Signed-off-by: Matthias Tafelmeier <[email protected]>
Necessary otherwise we get a dependencies out of sync error. Exact error: "the lock file (Chart.lock) is out of sync with the dependencies file (Chart.yaml). Please update the dependencies" Signed-off-by: Matthias Tafelmeier <[email protected]>
cherusk
force-pushed
the
feature/dask_executor
branch
from
9a115cf to
84a1520
Compare
Signed-off-by: Matthias Tafelmeier <[email protected]>
|
@thesuperzapper @gsemet could you please prioritize this up? Thanks! |
|
This issue has been automatically marked as stale because it has not had activity in 60 days. Thank you for your contributions. Issues never become stale if any of the following is true:
|
thesuperzapper
changed the title
DaskExecutor
|
@cherusk thanks for the PR, but it looks like as of Airflow 2.9.0, the upstream project has decided to stop supporting I understand that will be frustrating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
This PR brings about a new Airflow executor backend on Dask/Distributed cluster.
Checklist
For all Pull Requests