Handle setting geometry column name for GDAL 3.6+

[yohancabion]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 8388745198

Details

• 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.007%) to 98.499%

---

Totals
Change from base Build 7272942237:	0.007%
Covered Lines:	3543
Relevant Lines:	3597

---

💛 - Coveralls

[tbonfort]

I'm thinking we should change this method's signature to return an error, and explicitely return a go error without going into cgo/gdal for version>=3.6

[tbonfort]

or for version>3.9 actually no?

[yohancabion]

Comments and method signature changed. Tell me if it's ok so I squash commits.

[yohancabion]

When we look at the coverage, I wonder if we may create a cpp function so we check version in cpp code, like for other functions.

[tbonfort]

As you prefer. I am not very concerned by the coverage percent for this particular issue. If you were to move it all to cpp (which is effectively cleaner and a bit more in line with what we do elsewhere in godal), your coverage would still not be ideal as it would not be possible to write a test handling both the error and no-error cases.

[yohancabion]

New changes done. When moving to cpp, as errors are handled in a proper way, we don't even need to check version.

[tbonfort]

LGTM