Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version 8.0.0 #183

Merged
merged 16 commits into from
Apr 30, 2024
Merged

Release Version 8.0.0 #183

merged 16 commits into from
Apr 30, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Apr 16, 2024

Description

Release time!

@eeberhard if you want to make changes to the Contributing, Readme, etc, feel free to do this here.

The commits between version 7.2.0 and 7.3.0 show up because I made a mistake in the 7.3.0 release I think (squash and merge instead of merge commit or similar...)

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
Copy link
Member Author

domire8 commented Apr 16, 2024

It's all been tested here and the CI seems to do what we'd expect: https://github.com/domire8/control-libraries

bpapaspyros
bpapaspyros previously approved these changes Apr 16, 2024
Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

yrh012
yrh012 previously approved these changes Apr 16, 2024
Copy link

@yrh012 yrh012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@domire8 domire8 linked an issue Apr 16, 2024 that may be closed by this pull request
eeberhard
eeberhard previously approved these changes Apr 16, 2024
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂 🔥

Changelogs and readmes look great, thanks for the work to rewrite those alongside all of the other refactor work here.

Since we are closing develop branch now, you could also have made this release PR (which updates changelogs and versions) on develop, and then merge develop into main to officially close it. But I suppose since we are deleting develop anyway then it doesn't matter if it ends up being one commit behind!

So, LGTM, you can ship it 👍

@domire8 domire8 dismissed stale reviews from eeberhard, yrh012, and bpapaspyros via eaf5ea8 April 17, 2024 05:14
bpapaspyros
bpapaspyros previously approved these changes Apr 17, 2024
@eeberhard eeberhard marked this pull request as draft April 17, 2024 12:44
@domire8
Copy link
Member Author

domire8 commented Apr 25, 2024

@LouisBrunner Will your changes to the build system (dependency management) potentially require a new major version for control libraries? If that's the case I wonder if this PR should wait even a bit more

@LouisBrunner
Copy link

@LouisBrunner Will your changes to the build system (dependency management) potentially require a new major version for control libraries? If that's the case I wonder if this PR should wait even a bit more

Potentially. We haven't touched on that yet. I don't know if we want all the packages to be bumped one major version or if we are happy with a minor bump. Technically, it doesn't break the existing package so I would argue a minor bump would be enough.

@domire8 domire8 marked this pull request as ready for review April 30, 2024 11:57
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂 🔥

Thanks for taking your time with this release to consider the downstream impact. As far as I can tell, v8 is good to go now!

@domire8 domire8 merged commit 92f413b into main Apr 30, 2024
5 checks passed
@domire8 domire8 deleted the release/800 branch April 30, 2024 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp build structure
5 participants