Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add details for IBC Testing with Emerynet and Local Chain #6

Merged
merged 1 commit into from
Jul 25, 2024
Merged

docs: add details for IBC Testing with Emerynet and Local Chain #6

merged 1 commit into from
Jul 25, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Jul 25, 2024 •
edited
Loading

Addresses #7

@rabi-siddique rabi-siddique linked an issue Jul 25, 2024 that may be closed by this pull request
Document IBC Testing with Emerynet and Local Chain in the README #7
Closed
frazarshad
frazarshad reviewed Jul 25, 2024
View reviewed changes
Copy link

@frazarshad frazarshad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation looks good. but section above it (testing devnet with emerynet) is incorrect now since docker-compose-testnet.yaml does not contain a devnet chain anymore

@rabi-siddique
Copy link
Contributor Author

the documentation looks good. but section above it (testing devnet with emerynet) is incorrect now since docker-compose-testnet.yaml does not contain a devnet chain anymore

Thanks for pointing this out. I've addressed this in #9 and added a description for it in #10

@rabi-siddique rabi-siddique merged commit af1e77f into main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frazarshad frazarshad frazarshad approved these changes

@toliaqat toliaqat Awaiting requested review from toliaqat

@amessbee amessbee Awaiting requested review from amessbee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document IBC Testing with Emerynet and Local Chain in the README
2 participants
@rabi-siddique @frazarshad