-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boundary conditions #56
Commits on Feb 21, 2024
-
Initial implementation of boundary condition struct.
- Added structs for Boundary, BoundaryCondition, BoundaryDirection. - Added handling of grid boundary hitting event. - Added hard-coded default behaviour to all engines.
Configuration menu - View commit details
-
Copy full SHA for 34f9318 - Browse repository at this point
Copy the full SHA 34f9318View commit details
Commits on Apr 16, 2024
-
Initial integration of boundary condition into MCRT
- Improvement of boundary condition structs to work with MCRT. - Fixed bug where boundary hit finding would not be tolerant of rounding. - Integration of boundary condition into engines and MCRT main. - Added supporting ray-plane intersect function to support changes. - Removed dependence of engine and travel upon output grid that stretches across whole domain. Making way for more flexible output in the future.
Configuration menu - View commit details
-
Copy full SHA for 1b7921d - Browse repository at this point
Copy the full SHA 1b7921dView commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa9c6cd - Browse repository at this point
Copy the full SHA fa9c6cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59c4f43 - Browse repository at this point
Copy the full SHA 59c4f43View commit details
Commits on Aug 1, 2024
-
- Started refactor of output with new `io` module. - Added volume output + tests. - Added plane output + tests.
Configuration menu - View commit details
-
Copy full SHA for 5edde8e - Browse repository at this point
Copy the full SHA 5edde8eView commit details
Commits on Aug 13, 2024
-
Moved Photon collector to
io::output
.It makes more sense for the `PhotonCollector` struct to be contained in the output module, so I have moved it there. I have changed references in the code to point to this new location.
Configuration menu - View commit details
-
Copy full SHA for a1f0558 - Browse repository at this point
Copy the full SHA a1f0558View commit details -
Added
Output
struct inio::output
.This struct is intended as the new central object containing all of the output code for `mcrt`. It contains all of the other outputs. I am in the process of refactoring all of the output structs to work with this. - Added `Output` struct. - Added builder structs which support deserialisation from JSON to allow init from config. - Added supporting structs around output types to deserialise / integrate.
Configuration menu - View commit details
-
Copy full SHA for dbfc01a - Browse repository at this point
Copy the full SHA dbfc01aView commit details
Commits on Aug 14, 2024
-
Added first implementation of new output and builder.
- Output struct in `io` module now implemented. - Added Builder structure to deserialise and build Output. - Added supporting deserialisation, config and builder structs for output types. - Added voxel distance calculation to output volume to support next steps. - Added `OutputRegistry` to support output linking.
Configuration menu - View commit details
-
Copy full SHA for 660c22a - Browse repository at this point
Copy the full SHA 660c22aView commit details -
Added
output
section to parameters input.This now means that the output parameters can be read in as part of the main JSON5 input for the MCRT software. I had added a redirect here, so it can be included either in the same file, or separate. Also added output section to display.
Configuration menu - View commit details
-
Copy full SHA for f57a8be - Browse repository at this point
Copy the full SHA f57a8beView commit details -
Fixed
Output
voxel_dist function.This function was previously using an invalid min finding iter-chain. It also now sensibly returns f64::INFINITY instead of a None in the case of distance to a voxel being None (no voxel boundaries in path of packet).
Configuration menu - View commit details
-
Copy full SHA for c59df61 - Browse repository at this point
Copy the full SHA c59df61View commit details -
Starting integration of new
Output
object into MCRTThis commit adds new the new Output struct to the MCRT executable. Including implementing new types throughout the code and integrating into existing code. Some more specific comments on changes: - Modified engines and `travel` implementation to output into new objects. - Modified `mcrt` exec to use new output object. - Added extra implementations to clone output. - Added placeholder implementations of `Save` for `Output`.
Configuration menu - View commit details
-
Copy full SHA for 64e8a8a - Browse repository at this point
Copy the full SHA 64e8a8aView commit details -
These grids were too large and wouldn't compile on a computer with less RAM. I hadn't forgotten to change this back.
Configuration menu - View commit details
-
Copy full SHA for 33754c9 - Browse repository at this point
Copy the full SHA 33754c9View commit details
Commits on Aug 15, 2024
-
First working version with implementation tests.
- Added saving to new `Output` struct. - Added saving to output plane struct. - Converted voxel distance measurement in engines to new system. - Fixed bug where killed photons would continue to propagate in all engines.
Configuration menu - View commit details
-
Copy full SHA for 242e7d8 - Browse repository at this point
Copy the full SHA 242e7d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc97b55 - Browse repository at this point
Copy the full SHA dc97b55View commit details -
Added
Display
impl forOutput
andOutputConfig
.- Added Display implementations for supporting structs. - Fixed some warnings, mainly due to unneeded imports.
Configuration menu - View commit details
-
Copy full SHA for 7c9bcc2 - Browse repository at this point
Copy the full SHA 7c9bcc2View commit details -
Added boundary conditions config to MCRT.
Removed the grid config and replaced with the boundary conditions. Many changes to support these changes. Added structs and types to support deserialisation and building. Integrated into the MCRT binary. Note, this commit breaks the fluorescence engine, but I think we can work around this.
Configuration menu - View commit details
-
Copy full SHA for b871441 - Browse repository at this point
Copy the full SHA b871441View commit details -
Added potential fix for shift map indexing in
fluorescence
engine.The removal of the `grid` parameter also removed access to a consistent measurement grid over which to index into the shifts map in the fluorescence engine. However, I have engineered an alternate solution which indexes using the bounds of the simulation and takes from the res of the grid, potentially making this solution more flexible.
Configuration menu - View commit details
-
Copy full SHA for bf69dc2 - Browse repository at this point
Copy the full SHA bf69dc2View commit details