Boundary conditions #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added structs for Boundary, BoundaryCondition, BoundaryDirection. - Added handling of grid boundary hitting event. - Added hard-coded default behaviour to all engines.
- Improvement of boundary condition structs to work with MCRT. - Fixed bug where boundary hit finding would not be tolerant of rounding. - Integration of boundary condition into engines and MCRT main. - Added supporting ray-plane intersect function to support changes. - Removed dependence of engine and travel upon output grid that stretches across whole domain. Making way for more flexible output in the future.
EdHone
requested changes
Apr 18, 2024
src/geom/plane.rs
Outdated
There was a problem hiding this comment.
A test for this function would be nice
EdHone
approved these changes
Apr 25, 2024
|
Thanks for humoring my nitpicks! Merge away, Sam! |
- Started refactor of output with new `io` module. - Added volume output + tests. - Added plane output + tests.
It makes more sense for the `PhotonCollector` struct to be contained in the output module, so I have moved it there. I have changed references in the code to point to this new location.
This struct is intended as the new central object containing all of the output code for `mcrt`. It contains all of the other outputs. I am in the process of refactoring all of the output structs to work with this. - Added `Output` struct. - Added builder structs which support deserialisation from JSON to allow init from config. - Added supporting structs around output types to deserialise / integrate.
- Output struct in `io` module now implemented. - Added Builder structure to deserialise and build Output. - Added supporting deserialisation, config and builder structs for output types. - Added voxel distance calculation to output volume to support next steps. - Added `OutputRegistry` to support output linking.
This now means that the output parameters can be read in as part of the main JSON5 input for the MCRT software. I had added a redirect here, so it can be included either in the same file, or separate. Also added output section to display.
This function was previously using an invalid min finding iter-chain. It also now sensibly returns f64::INFINITY instead of a None in the case of distance to a voxel being None (no voxel boundaries in path of packet).
This commit adds new the new Output struct to the MCRT executable. Including implementing new types throughout the code and integrating into existing code. Some more specific comments on changes: - Modified engines and `travel` implementation to output into new objects. - Modified `mcrt` exec to use new output object. - Added extra implementations to clone output. - Added placeholder implementations of `Save` for `Output`.
These grids were too large and wouldn't compile on a computer with less RAM. I hadn't forgotten to change this back.
- Added saving to new `Output` struct. - Added saving to output plane struct. - Converted voxel distance measurement in engines to new system. - Fixed bug where killed photons would continue to propagate in all engines.
- Added Display implementations for supporting structs. - Fixed some warnings, mainly due to unneeded imports.
Removed the grid config and replaced with the boundary conditions. Many changes to support these changes. Added structs and types to support deserialisation and building. Integrated into the MCRT binary. Note, this commit breaks the fluorescence engine, but I think we can work around this.
The removal of the `grid` parameter also removed access to a consistent measurement grid over which to index into the shifts map in the fluorescence engine. However, I have engineered an alternate solution which indexes using the bounds of the simulation and takes from the res of the grid, potentially making this solution more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented boundary conditions. Includes structures, supporting code and basic integration into MCRT code. Also includes some unit tests.