fix: case-insensitive curator comment + fix logger.warning statement

[seasidesparrow]

modified:   adsdocmatch/oracle_util.py

Fixes Issue #22

[seasidesparrow]

This PR also adds a method to access the /cleanup endpoint of oracle_service, along with unit tests.

[golnazads]

I would get the message returned from oracle and display it. There are three types of cleanup details are here https://github.com/adsabs/oracle_service/blob/master/oraclesrv/views.py#L382

[seasidesparrow]

I refactored this to return response.text and modified the tests accordingly

[golnazads]

No, not quit.

Here is what I would do (lines between double stars)

def cleanup_db(self):
    """

    :param:
    :return:
    """
  
    try:
        sleep_sec = int(config.get('DOCMATCHPIPELINE_API_ORACLE_SERVICE_SLEEP_SEC', 5))
        num_attempts = int(config.get('DOCMATCHPIPELINE_API_ORACLE_SERVICE_ATTEMPTS', 5))
        for i in range(num_attempts):
            response = requests.get(
                url=config.get('DOCMATCHPIPELINE_API_ORACLE_SERVICE_URL', 'http://localhost') + '/cleanup',
                headers={'Authorization': 'Bearer %s' % config.get('DOCMATCHPIPELINE_API_TOKEN', '')})
            status_code = response.status_code
            if status_code == 200:
                logger.info('Got 200 for status_code at attempt # %d' % (i + 1))
                break
            elif status_code in [500, 502, 504]:
                logger.info('Got %d status_code from oracle, waiting %d second and attempt again.' % (
                status_code, num_attempts))
                time.sleep(sleep_sec)
            # any other error, quit
            else:
                logger.info('Got %s status_code from a call to oracle, stopping.' % status_code)
                break
        **json_text = json.loads(response.text)**
        **message = json_text.get('message', '')**
        if status_code == 200:
            **logger.info('Cleanup command issued to oracle database, got response %s.'%message)**
        else:
            **logger.warning('Unable to issue cleanup command to oracle_service, service returned status code %s with message %s on final try' % (status_code, message))**
        **return message**
    except Exception as err:
        logger.error("Error from cleanup_db: %s" % err)
        return "Error from cleanup_db: %s" % err

[golnazads]

Matt, did not like the field message, just renamed it to details in oracle, I think makes more sense. If you would please make the change here. Also for testing, here is the unittest in oracle if you want to see what messages are brought back from cleanup https://github.com/adsabs/oracle_service/blob/master/oraclesrv/tests/unittests/test_oracle_service.py#L762.

[seasidesparrow]

These changes have been made, thanks!

[golnazads]

Great job. Thank you.