Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image links #199

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Add support for image links #199

merged 4 commits into from
Aug 20, 2024

Conversation

chrischrischris
Copy link
Contributor

@chrischrischris chrischrischris commented Aug 19, 2024

Create linked images by setting href and title attributes on img elements. This is then converted to an <a> surrounding the picture element.

Requires da-collab PR: adobe/da-collab#47

URL for testing:

Copy link

aem-code-sync bot commented Aug 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 20, 2024

Page Scores Audits Google
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@chrischrischris chrischrischris merged commit f8a4461 into main Aug 20, 2024
6 checks passed
@chrischrischris chrischrischris deleted the image-links branch August 20, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants