Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on Images not currently working in DA #194

Open
treeves opened this issue Aug 14, 2024 · 2 comments
Open

Links on Images not currently working in DA #194

treeves opened this issue Aug 14, 2024 · 2 comments

Comments

@treeves
Copy link

treeves commented Aug 14, 2024

Expected Behaviour

Adding a link to an image should result in an tag wrapping the image.

Actual Behaviour

Links are being stripped and don't make it out to the preview or live hlx pages.

Reproduce Scenario (including but not limited to)

See https://da.live/edit#/jmphlx/jmp-da/0-sandbox/craig-test/modal-play-button-test

and https://main--jmp-da--jmphlx.hlx.live/0-sandbox/craig-test/modal-play-button-test

Link wrapped on the play button (or ANY image) should allow for a clickable link, but no sign of the link or alt shows up in the generated HTML

Steps to Reproduce

See above

Platform and Version

Browser (any)

Sample Code that illustrates the problem

For https://main--jmp-da--jmphlx.hlx.page/0-sandbox/tad-test/video-test / https://da.live/edit#/jmphlx/jmp-da/0-sandbox/tad-test/video-test

The generated HTML is only:

Test

--   |

  |   |   |   |   |   |

Logs taken while reproducing problem

None

@bosschaert
Copy link
Contributor

It looks like this is caused by yjs/y-prosemirror#165

@auniverseaway
Copy link
Member

Fixed with #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants